shrink readme, remove dead code, remove debug mode, remove 7z benchmark

-D was referencing to ix.io which has been dead for years now and nobody complained
7z benchmark was interesting years ago when sbcs weren't as powerful as they are today. Perhaps also here reference to sbcbench for proper results.

Author: EvilOlaf

packages/bsp/common/usr/bin/armbianmonitor

@@ -2,82 +2,33 @@
 #
 # armbianmonitor
 #
-# This script serves different purposes based on how it is called:
+# System monitoring and debugging utility for Armbian.
+# Part of the Armbian project - https://www.armbian.com
 #
-# - toggle boot verbosity (works)
-# - monitoring mode: continually print monitoring info (WiP)
-# - uploading /var/log/armbian-hardware-monitor.log to online pastebin service
+# Features:
+# - Live system monitoring (CPU, temp, voltage, etc.)
+# - Network monitoring
+# - Disk I/O monitoring
+# - Disk health/performance testing
+# - Package integrity verification
 #
-# Without arguments called it should present a simple user
-# interface that guides through:
+# For support info collection and upload, use 'armbian-debug'.
 #
-# - installation of RPi-Monitor if not already installed by user
-# - active basic or more verbose monitoring mode
-# - provides monitoring parameters for connected disks
+# Disk Configuration Format:
+# When checking disks, proposals are generated for /etc/armbianmonitor/disks.conf:
 #
-# The second part is WiP and all the user interaction part
-# still completely missing.
+#   ${GUID}:${Name}:${smartctl_prefix}:${temp_call}:${CRC}:${LCC}
 #
-# This script is used to configure armbianmonitor behaviour.
-# It will ask the user whether to activate monitoring or not,
-# whether to enable debug monitoring and also how to deal with
-# connected disks. In fact it walks through the list of available
-# disks, checks them, tries to patch hddtemp.db if necessary
-# and provides a proposal for /etc/armbianmonitor/disks.conf
-# when a new disk is found.
+# Fields:
+#   - GUID: Disk identifier from gdisk
+#   - Name: Display name (defaults to device model)
+#   - smartctl_prefix: USB disk type prefix (e.g., '-d sat', '-d usbjmicron')
+#   - temp_call: Command to get temperature (omit to use hddtemp)
+#   - CRC: S.M.A.R.T. attribute number for CRC errors
+#   - LCC: S.M.A.R.T. attribute number for load cycle count
 #
-# In case monitoring should be activated the following file
-# will be created: /etc/armbianmonitor/start-monitoring. If
-# debug output has been chosen, then DEBUG will be written to
-# the file.
-#
-# The script will install smartmontools/gdisk if not already
-# installed and patches smartmontools' update-smart-drivedb
-# script if necessary. For disks the 'device model' will be
-# shown but internally we rely always on the GUID. This is the
-# key for entry in /etc/armbianmonitor/disks.conf
-#
-# When the script exits and the user activated monitoring it
-# recommends doing a restart since on the next reboot the
-# setup-armbian-monitoring-environment script will configure
-# monitoring sources and decides based on the existence and
-# contents of /etc/armbianmonitor/start-monitoring whether
-# rpimonitord should be started or not.
-#
-# The format of /etc/armbianmonitor/disks.conf is as follows:
-#
-# ${GUID}:${Name}:${smartctl prefix}:${temp call}:${CRC}:${LCC}
-#
-# Two examples:
-#
-# A57BF307-7D82-4783-BD1D-B346CA8C195B:WD Green::199:193 # WD HDD on SATA
-# F8D372DC-63DB-494B-B802-87DC47FAD4E1:Samsung EVO:sat::199: # SSD in USB enclosure
-#
-# - GUID is the GUID as determined by gdisk
-# - 'Name': The name as it will later be shown in RPi-Monitor, defaults to
-#   the 'device model' read out through smartctl but can be changed to
-#   be more significant (beware that this string must contain colons!)
-# - "smartctl prefix" can be empty or should be the the necessary prefix for
-#   USB disks, eg. '-d sat' or '-d usbjmicron' and so on -- please have a
-#   look at https://www.smartmontools.org/wiki/Supported_USB-Devices
-# - "temp call" when being omitted indicates that hddtemp should be used.
-#   Otherwise it should contain the complete command line ('DISK' will be
-#   dynamically replaced by the device node when the actual monitoring
-#   happens), for example:
-#   /sbin/hdparm -C DISK | grep -Eq "standby|sleeping" || \
-#   /usr/sbin/smartctl -d sat -a DISK | awk -F" " '/Temperature_Cel/ {printf $10}'
-# - 'CRC attribute': The decimal value of the S.M.A.R.T. attribute that
-#   is used to store the count of checksum errors between disk and host
-#   controller (might be omitted if the drive doesn't support it)
-# - 'LCC attribute': The decimal value of the S.M.A.R.T. attribute that
-#   should contain the load cycle counter value (might be omitted
-#   if the drive doesn't support it)
-#
-# TODO:
-#
-# - develop main functionality ;) asking the user regarding monitoring
-# - deal with 'SMART overall-health self-assessment test result:'
-# - write documentation
+# Example:
+#   A57BF307-7D82-4783-BD1D-B346CA8C195B:WD Green::199:193
 #
 ############################################################################
 
@@ -102,29 +53,10 @@ Main() {
 	)
 
 	ParseOptions "$@"
-
-	exit 0
-	PreRequisits
-
-	# check whether user runs rpimonitord on his own or we activated it
-	if [ -f /etc/armbianmonitor/start-monitoring ]; then
-		# we should already provide monitoring, check whether DEBUG
-		# is also set
-		ArmbianMonitoring=TRUE
-		read -r DebugMode < /etc/armbianmonitor/start-monitoring 2> /dev/null
-	fi
-
-	# check whether rpimonitord is running and compare with ${ArmbianMonitoring}
-	# In case the user chose to run rpimonitord on his own, we skip the config
-	# part and only output disk info
-	:
-
-	# check available disk devices
-	CheckDisks
 } # Main
 
 ParseOptions() {
-	while getopts 'hHuUrRmMsnNd:Dc:C:pPvz' c; do
+	while getopts 'hHuUrRmMsnNd:c:C:pPv' c; do
 		case ${c} in
 			H)
 				# display full help test
@@ -173,31 +105,6 @@ EOF
 				MonitorIO "${OPTARG}"
 				exit 0
 				;;
-			D)
-				fping ix.io 2> /dev/null | grep -q alive ||
-					(
-						echo "Network/firewall problem detected. Please fix this prior to installing RPi-Monitor." >&2
-						exit 1
-					)
-				DebugOutput="$(mktemp /tmp/${0##*/}.XXXXXX)"
-				trap "rm \"${DebugOutput}\" ; exit 0" 0 1 2 3 15
-				set -x
-				exec 2> "${DebugOutput}"
-				PreRequisits > /dev/null 2>&1
-				CheckDisks
-				which curl > /dev/null 2>&1 || apt-get -f -qq -y install curl
-				echo -e "\nDebug output has been collected at the following URL: \c"
-				(
-					cat "${DebugOutput}"
-					echo -e "\n\n\ngdisk.txt contents:\n"
-					cat "${MyTempDir}/gdisk.txt"
-					echo -e "\n\n\nsmartctl.txt contents:\n"
-					cat "${MyTempDir}/smartctl.txt"
-				) |
-					curl -F 'f:1=<-' ix.io
-				echo -e "Please post the URL in the Armbian forum where you've been asked for."
-				exit 0
-				;;
 			c | C)
 				# check card mode
 				CheckCard "${OPTARG}"
@@ -209,12 +116,6 @@ EOF
 				VerifyInstallation
 				exit 0
 				;;
-			z)
-				# Do a quick 7-zip benchmark to estimate CPU performance
-				runs=$2
-				Run7ZipBenchmark 2> /dev/null
-				exit 0
-				;;
 			*)
 				echo "Invalid flag: ${c}" >&2
 				exit 7
@@ -231,18 +132,16 @@ DisplayUsage() {
 	#		grep "^#" "$0" | grep -v "^#\!/bin/bash" | sed 's/^#//'
 	#	fi
 	echo
-	echo "Usage: $(basename $0) [-h] [-c \$path] [-d \$device] [-D] [-m] [-n] [-v] [-z]"
+	echo "Usage: $(basename $0) [-h] [-c \$path] [-d \$device] [-m] [-n] [-v]"
 	echo
 	echo "Options:"
 	echo "  -c /path/to/test   Performs disk health/performance tests"
 	echo "  -d                 Monitors writes to \$device"
-	echo "  -D                 Tries to upload debug disk info to improve armbianmonitor"
 	echo "  -m                 Provides simple CLI monitoring - scrolling output"
 	echo "  -M                 Provides simple CLI monitoring - fixed-line output"
 	echo "  -n                 Provides simple CLI network monitoring - scrolling output"
 	echo "  -N                 Provides simple CLI network monitoring - fixed-line output"
 	echo "  -v                 Tries to verify installed package integrity"
-	echo "  -z                 Runs a quick 7-zip benchmark to estimate CPU performance"
 	echo
 	echo "Note: The -u/-U options for support info upload are deprecated."
 	echo "      Use the 'armbian-debug' command instead."
@@ -932,32 +831,4 @@ kickAllStatsDown() {
 	cnt=0
 }
 
-Run7ZipBenchmark() {
-	echo -e "Preparing benchmark. Be patient please..."
-	# Do a quick 7-zip benchmark, check whether binary is there. If not install it
-	MyTool=$(which 7za || which 7zr)
-	[ -z "${MyTool}" ] && apt-get -f -qq -y install p7zip && MyTool=/usr/bin/7zr
-	[ -z "${MyTool}" ] && (
-		echo "No 7-zip binary found and could not be installed. Aborting" >&2
-		exit 1
-	)
-	# Send CLI monitoring to the background to be able to spot throttling and other problems
-	MonitoringOutput="$(mktemp /tmp/${0##*/}.XXXXXX)"
-	trap "rm \"${MonitoringOutput}\" ; exit 0" 0 1 2 3 15
-	armbianmonitor -m > ${MonitoringOutput} &
-	MonitoringPID=$!
-	# run 7-zip benchmarks after waiting 10 seconds to spot whether the system was idle before.
-	# We run the benchmark a single time by default unless otherwise specified on the command line
-	RunHowManyTimes=${runs:-1}
-	sleep 10
-	for ((i = 1; i <= RunHowManyTimes; i++)); do
-		"${MyTool}" b
-	done
-	# report CLI monitoring results as well
-	kill ${MonitoringPID}
-	echo -e "\nMonitoring output recorded while running the benchmark:\n"
-	sed -e '/^\s*$/d' -e '/^Stop/d' < ${MonitoringOutput}
-	echo -e "\n"
-} # Run7ZipBenchmark
-
 Main "$@"