k3-beagle: fix malformed csi0-imx219 overlay patch (bad hunk count)#10136
Conversation
The BeagleY-AI CSI0 IMX219 overlay patch failed to apply on edge/6.18
kernel builds:
patch: **** malformed patch at line 152: --
Failed to parse unidiff ... 'Hunk is longer than expected'
The new-file hunk header declared "@@ -0,0 +1,130 @@" but the body
contains only 128 added lines, so patch(1) ran past the hunk and
consumed the "--"/"2.43.0" git signature footer. The footer's trailing
space had also been stripped ("--" instead of "-- ").
Correct the hunk count to 128, align the diffstat (128/129 insertions),
and restore the "-- " signature separator. The overlay content is
unchanged and complete (brace/bracket balanced). Verified with both
`git apply --check` and `patch -p1 --dry-run` (exit 0).
Signed-off-by: Igor Pecovnik <igor@armbian.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Disabled knowledge base sources:
📝 WalkthroughWalkthroughAdds a kernel DT overlay patch for BeagleY-AI that enables an IMX219 camera on CSI0, including power, reset, I2C, and CSI-2 endpoint configuration, and registers the overlay in the K3 build list. ChangesIMX219 CSI0 Overlay
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
The BeagleY-AI CSI0 IMX219 overlay patch fails to apply on edge / linux-6.18.y kernel builds (board
beagley-ai, familyk3-beagle), breaking the kernel artifact:Root cause
In
0003-arm64-dts-ti-add-beagley-ai-csi0-imx219-overlay.patch, the new-file hunk header declared@@ -0,0 +1,130 @@but the body contains only 128 added lines.patch(1)therefore ran past the hunk and consumed the--/2.43.0git signature footer as diff body. The footer's trailing space had also been stripped (--instead of--).Fix
+1,130→+1,128128/129 insertions(+))--signature separatorThe overlay content is unchanged and complete (brace/bracket balanced — 21/21
{}, 36/36<>).Verification
Both tools that failed in the build now pass against a matching Makefile context:
git apply --check→ exit 0patch -p1 --dry-run→ exit 0Note: this fixes the patch envelope only. Ideally the same correction lands at the source (original patch author) so it doesn't regress on the next import.
Summary by CodeRabbit