Skip to content

Use relative symbolic links for some BSP files#10145

Open
retro98boy wants to merge 1 commit into
armbian:mainfrom
retro98boy:relative-symbolic-links
Open

Use relative symbolic links for some BSP files#10145
retro98boy wants to merge 1 commit into
armbian:mainfrom
retro98boy:relative-symbolic-links

Conversation

@retro98boy

@retro98boy retro98boy commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

How Has This Been Tested?

Build the full imgs for these boards to make sure the compilation doesn't fail. Then use losetup to check if the symlinks inside the image are correct.

Summary by CodeRabbit

  • Bug Fixes
    • Improved audio configuration setup during installation so the needed directories are created consistently.
    • Updated sound profile links to use more reliable relative paths, helping prevent missing or broken audio configuration on supported devices.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Three board configuration scripts modify their post_family_tweaks_bsp functions for ALSA UCM setup: directory creation switches from conditional (if [ ! -d ... ]) to unconditional mkdir -p, and symlink targets for sound-card conf files change from absolute paths to relative paths.

Changes

ALSA UCM directory and symlink updates

Layer / File(s) Summary
Unconditional mkdir and relative symlinks
config/boards/bestv-r3300-l.csc, config/boards/cainiao-cniot-core.csc, config/boards/norco-emb-3531.csc
Each board's post-install tweak now uses mkdir -p unconditionally for its ALSA UCM conf.d directory and creates the sound-card config symlink using a relative path instead of an absolute path.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested labels: Patches

Suggested reviewers: SuperKali, paolosabatino, HeyMeco

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: converting some BSP symlinks to relative paths.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added 08 Milestone: Third quarter release size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

08 Milestone: Third quarter release Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

1 participant