To modify the PWM-fan temperature control policy of fine3399 to adjust the fan speed to a lower level

[Lemon1151]

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

To modify the PWM-fan temperature control policy of fine3399 to adjust the fan speed to a lower level.
Integrating support for xiaobaonas and fine3399 boards into the rockchip64-6.9 kernel

Documentation summary for feature / change

Please delete this section if entry to main documentation is not needed.

If documentation entry is predicted, please provide key elements for further implementation into main documentation and set label to "Needs Documentation". You are welcome to open a PR to documentation or you can leave following information for technical writer:

• short description (copy / paste of PR title)
• summary (description relevant for end users)
• example of usage (how to see this in function)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

• Test A
• Test B

Checklist:

Please delete options that are not relevant.

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules

[EvilOlaf]

It might be better to use bare dt instead of patches as in the PRs below:
#6824
#6842

[Lemon1151]

It's been a week, why hasn't the review been conducted yet? Could it be that the submitted patch will cause issues with the source code compilation?

[igorpecovnik]

It's been a week

Our review capacity is very small. We try to get more people on this https://forum.armbian.com/staffapplications/application/23-code-reviewer/ but there is sadly not much interest. Review is hard and inglorious work ... I am open for ideas what else we could try?

[EvilOlaf]

I made a comment about concerns but whatever...

[amazingfate]

It might be better to use bare dt instead of patches as in the PRs below:

Several months later and I come here to say that this concern is reasonable, this commit is breaking armbian's style and will make other people confused when looking at the code. The patch does not include changes to Makefile, why it worked before is because there is already dts in dt dir. And now that dts file is gone in rockchip64-6.11, so this board is not supported by 6.11.

[Lemon1151]

Thank you very much for pointing out the issue. Your concern is correct. Should I submit the kernel DTS device tree files to the dt directory instead of submitting kernel patch files?

[EvilOlaf]

Yeah would be nice. A few files less to worry about when the next major kernel version hits :)