actions(update-tools): avoid notifying our outdated deps everywhere #7709
+2
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
In the current main branch, workflow
update-tools
includes the content of the upstream release notes in the created GitHub Issue. This triggers a notification to every upstream contributor mentioned in the release note. This also creates a cross-reference link to our GitHub issue, which reports that our dependency is not up-to-date, in every issue and pull request in the upstream. The information that we need to update our dependency is not relevant to the upstream contributors, issues, and pull requests at all. We should avoid this situation.In addition, this project has thousands of forks, and all the fork repositories that enabled GitHub Actions do the same at the same time, i.e., an upstream contributor receives several tens of notifications from fork repositories, and an upstream issue receives several tens of cross-reference links to fork repositories. We should have avoided this situation, but it's kind of too late. Even if we update the workflow specification in this repository, the workflow of the fork won't be updated unless the fork pulls our latest commit. We need to ask all these 54 fork repositories currently generating notifications one by one. Anyway, we should still consider updating our workflow to prevent future forks from starting to create an even larger number of notifications to the upstream contributors and issues.
First, we do not need to include a copy of the upstream release note. We can just put a link to the upstream release note. Currently, we anyway hide the content in the
<details>
tag and require the reader to press the button. The user experience is not so different from pressing a link and visiting the upstream release note.GitHub issue reference: #7706
Jira reference number [AR-9999]
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.
I have run the workflow in my fork repository:
https://github.com/akinomyoga/armbian-build/actions/workflows/update-tools.yml
and observed the results:
https://github.com/akinomyoga/armbian-build/pulls
Checklist:
Please delete options that are not relevant.