-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP sunxi 6.6: Cleaning up the patches before the changes. Swith to v6.6.72 #7714
Conversation
Undo changes that are made massively and create a lot of noise. armbian@e103e2e
Undo changes that are made massively and create a lot of noise. armbian@e103e2e
Undo changes that are made massively and create a lot of noise. armbian@e103e2e
…eries. Remove unnecessary patch fixes, and also move the time-tested patch to the armbian series as permanently supported.
I wonder why e103e2e is creating a lot of noise. Now the patches are looking worse after the revert. |
diff --git a/arch/arm/kernel/patch.c b/arch/arm/kernel/patch.c
index e9e828b6bb30..f003867f085a 100644
index 111111111111..222222222222 100644
--- a/arch/arm/kernel/patch.c
+++ b/arch/arm/kernel/patch.c It's a noise. There are no changes.
Please provide an example. |
I think @rpardini should should also be asked about this as the author of the PR that made that commit: #7651. There is a reason that PR was made and merged, though I do not have much experience with patches to understand the details, pros and cons. We should decide which form is better and should be used, or else we could get stuck in going back-and-forth reverting and reapplying the same processes. And also i think working with patches right now is a bit complicated, everyone has their own different workflow. Making a guide or just a page describing the best process in armbian documentation would help. |
diff index hash in patch file is meaningless. If you use git am command to apply the patch, and then use command git format-patch to re-generate the patch, the hash value always changes when the base repo is updated. That's why rewrite-kernel-patches is always replacing the hash value to Armbian's build framework runs on many distributions with different git version, and the git version at the end of patch file is meaningless, so we replace it with It's recommendded that all patches should be re-formatted with rewrite-kernel-patches. |
Explanations: Maybe I just want to draw someone's attention to the problem
In order not to create noise, my script uses intelligent copying. |
Your script ignores lines what rewrite- kernel-patches is overwriting, which should work exactly the same as rewrite-kernel-patches to show only the real changes of patch files. Here is my opinion on whether overwriting or ignore hash values in patch files: |
The first test build. |
Description
revert commit changes e103e2e1daa2d
Undo changes that are made massively and create a lot of noise.
Remove unnecessary patch fixes, and also move the time-tested patch to the armbian series as permanently supported.
Swith to v6.6.72
How Has This Been Tested?