Skip to content

Cloud images: enable video console and add two packages #8117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Apr 24, 2025

Description

  • Enable video console on amd64 cloud images - for remote console access
  • Enable video console on aarch64 cloud images - for remote console access
  • Add additional packages to cloud images

How Has This Been Tested?

  • Tested on aarch64 netcup cloud

Checklist:

  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@igorpecovnik igorpecovnik requested a review from rpardini as a code owner April 24, 2025 10:36
Copy link
Contributor

coderabbitai bot commented Apr 24, 2025

Walkthrough

The changes update kernel configuration files for both ARM64 and x86 UEFI cloud environments and modify a build script for image packaging. In the ARM64 kernel configuration, the legacy VESA framebuffer driver option is removed, while EFI framebuffer support, Direct Rendering Manager (DRM) core, simple DRM driver, DRM KMS helper, DRM framebuffer device emulation with overallocation, and font rendering support with specific font sizes are enabled. Similar DRM and font support options are added to the x86 UEFI cloud kernel configuration without removing existing options. Separately, the build script for UEFI-based cloud images is modified to include the qemu-guest-agent and spice-vdagent packages in the image for the cloud branch, with a debug alert message indicating their inclusion. No changes are made to exported or public function, class, or variable declarations in the codebase.

Suggested labels

ready to merge


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 73b0a21 and e6e62b8.

📒 Files selected for processing (2)
  • config/kernel/linux-uefi-x86-cloud.config (1 hunks)
  • config/sources/families/include/uefi_common.inc (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • config/sources/families/include/uefi_common.inc
  • config/kernel/linux-uefi-x86-cloud.config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... size/small PR with less then 50 lines 05 Milestone: Second quarter release labels Apr 24, 2025
@coderabbitai coderabbitai bot added the Ready to merge Reviewed, tested and ready for merge label Apr 30, 2025
@igorpecovnik igorpecovnik merged commit 9c5eddf into main Apr 30, 2025
12 checks passed
@igorpecovnik igorpecovnik deleted the consolecloud branch April 30, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
05 Milestone: Second quarter release Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

1 participant