Skip to content

Fix errors in .editorconfig#9363

Merged
igorpecovnik merged 1 commit into
armbian:mainfrom
iav:fix/editorconfig
Feb 8, 2026
Merged

Fix errors in .editorconfig#9363
igorpecovnik merged 1 commit into
armbian:mainfrom
iav:fix/editorconfig

Conversation

@iav

@iav iav commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

Fix two errors in .editorconfig since #4266:

  1. [*.md] section: Replace incorrect insert_final_newline = false with
    trim_trailing_whitespace = false.
    Markdown uses trailing whitespace (two spaces at end of line) to produce hard line
    breaks per the CommonMark spec.
    Trimming trailing whitespace would break this functionality. Meanwhile, disabling
    insert_final_newline for markdown files was unintentional — final newlines should be
    preserved per POSIX and the global [*] section already sets it to true.

  2. [*.{yaml,yml}] section: Remove redundant insert_final_newline = false.
    YAML files should end with a final newline, as required by [POSIX](https://pubs.open
    group.org/onlinepubs/9699919799.2008edition/basedefs/V1_chap03.html#tag_03_403) and
    expected by most YAML linters. The global [*] section already sets
    insert_final_newline = true, so the per-section override to false was incorrect.

Summary by CodeRabbit

  • Chores
    • Updated development configuration settings for code formatting standards across project files.

@iav iav requested a review from igorpecovnik as a code owner February 6, 2026 01:18
@coderabbitai

coderabbitai Bot commented Feb 6, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Configuration update to .editorconfig file adjusts trailing whitespace handling for Markdown files and modifies the newline policy for YAML files. Total changes: 1 line added, 2 lines removed.

Changes

Cohort / File(s) Summary
Editor Configuration
.editorconfig
Updated Markdown file handling to disable trailing whitespace trimming; removed explicit newline insertion setting for YAML files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A tiny tweak to how we write,
No trailing spaces left in sight,
YAML files now find their way,
With simpler rules for every day! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix errors in .editorconfig' directly summarizes the main change—correcting incorrect settings in the .editorconfig file that were introduced by a previous PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size/small PR with less then 50 lines 02 Milestone: First quarter release Needs review Seeking for review labels Feb 6, 2026
@github-actions github-actions Bot added the Ready to merge Reviewed, tested and ready for merge label Feb 6, 2026
@github-actions

github-actions Bot commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions Bot removed the Needs review Seeking for review label Feb 6, 2026
@igorpecovnik igorpecovnik merged commit 5269c8c into armbian:main Feb 8, 2026
12 checks passed
@iav iav deleted the fix/editorconfig branch February 8, 2026 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

02 Milestone: First quarter release Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

3 participants