Fix errors in .editorconfig#9363
Merged
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughConfiguration update to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rpardini
approved these changes
Feb 6, 2026
Contributor
|
✅ This PR has been reviewed and approved — all set for merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two errors in
.editorconfigsince #4266:[*.md]section: Replace incorrectinsert_final_newline = falsewithtrim_trailing_whitespace = false.Markdown uses trailing whitespace (two spaces at end of line) to produce hard line
breaks per the CommonMark spec.
Trimming trailing whitespace would break this functionality. Meanwhile, disabling
insert_final_newlinefor markdown files was unintentional — final newlines should bepreserved per POSIX and the global
[*]section already sets it totrue.[*.{yaml,yml}]section: Remove redundantinsert_final_newline = false.YAML files should end with a final newline, as required by [POSIX](https://pubs.open
group.org/onlinepubs/9699919799.2008edition/basedefs/V1_chap03.html#tag_03_403) and
expected by most YAML linters. The global
[*]section already setsinsert_final_newline = true, so the per-section override tofalsewas incorrect.Summary by CodeRabbit