phytiumpi - ATF_SKIP_LDFLAGS_WL="yes"

[tabrisnet]

Description

more LDFLAGS vs CFLAGS and --no-warn-rwx-segments pain 🍞
https://paste.armbian.com/ekulogumex <-- shows bug
https://paste.armbian.com/gexirupepe <-- shows it apparently fixed.

partially related to #9162

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

• time nice -n 19 ./compile.sh artifact BETA=yes BOARD=phytiumpi BRANCH=current BUILD_DESKTOP=no BUILD_MINIMAL=yes RELEASE=forky KERNEL_CONFIGURE=no KERNEL_GIT=full MANAGE_ACNG='http://squid.tabris.net:3142/' COMPRESS_OUTPUTIMAGE=xz DEB_COMPRESS=xz EXPERT=yes WHAT=uboot REVISION=26.2.0-trunk.450 ARTIFACT_IGNORE_CACHE=yes
  • https://paste.armbian.com/gexirupepe <-- shows it apparently fixed.

Checklist:

Please delete options that are not relevant.

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings

Summary by CodeRabbit

• Chores
  • Updated build configuration for PhytiumPi board to optimize the compilation process.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

---

📝 Walkthrough

Walkthrough

A global variable ATF_SKIP_LDFLAGS_WL set to "yes" has been added to the phytiumpi board configuration file. This is a configuration-only change with no modifications to existing functions or control flow.

Changes

Cohort / File(s)	Summary
Configuration Variable config/boards/phytiumpi.conf	Added global variable declaration declare -g ATF_SKIP_LDFLAGS_WL="yes"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A variable hops into view,
ATF_SKIP_LDFLAGS_WL shines so true,
In phytiumpi's config it takes its place,
One little line, zero frills—a rabbit's graceful trace. 🐰✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly references the specific configuration change being made: adding ATF_SKIP_LDFLAGS_WL="yes" to the phytiumpi board config file. It clearly summarizes the main change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[rpardini]

Yep. If this fixes it, is cos some vendor code calls ld directly instead of through cc and thus this is required, as there is no other way to know...

[github-actions]

✅ This PR has been reviewed and approved — all set for merge!