rockchip: Add CSC board EByte ECB41-PGE (RK3506G)#9513
rockchip: Add CSC board EByte ECB41-PGE (RK3506G)#9513vidplace7 wants to merge 1 commit intoarmbian:mainfrom
Conversation
📝 WalkthroughWalkthroughThis pull request introduces support for the EByte ECB41-PGE board, a Rockchip RK3506G2-based embedded system with 128MB RAM. Changes include board configuration metadata, U-Boot build flags and subsystem enablements, device tree U-Boot boot-phase properties, and complete hardware peripheral definitions across SPI flash, Ethernet, SD card, USB, UART, and power rail configurations. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚫 Missing required board assetsThis PR adds new board configuration(s). Required assets must already exist in github/armbian/armbian.github.io.
Missing items
Once the missing files are added (or a PR is opened in armbian/armbian.github.io), re-run this check. |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
patch/u-boot/u-boot-rk3506/dt/rk3506g-ebyte-ecb41-pge.dts (1)
12-17: Minor style inconsistency in aliases syntax.The
ethernet0andethernet1aliases use phandle syntax with angle brackets (<&gmac0>), whilemmc0andserial0use direct path references (&sdmmc). Both forms work, but for consistency, consider using the direct reference form throughout.🎨 Suggested fix for consistency
aliases { - ethernet0 = <&gmac0>; - ethernet1 = <&gmac1>; + ethernet0 = &gmac0; + ethernet1 = &gmac1; mmc0 = &sdmmc; serial0 = &uart0; };🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@patch/u-boot/u-boot-rk3506/dt/rk3506g-ebyte-ecb41-pge.dts` around lines 12 - 17, The aliases block mixes phandle angle-bracket syntax and direct references; update aliases ethernet0 and ethernet1 to use the same direct-reference form as mmc0 and serial0 by replacing <&gmac0> and <&gmac1> with &gmac0 and &gmac1 respectively so aliases (ethernet0, ethernet1, mmc0, serial0) consistently use direct phandle references to gmac0, gmac1, sdmmc, and uart0.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@patch/u-boot/u-boot-rk3506/dt/rk3506g-ebyte-ecb41-pge.dts`:
- Around line 12-17: The aliases block mixes phandle angle-bracket syntax and
direct references; update aliases ethernet0 and ethernet1 to use the same
direct-reference form as mmc0 and serial0 by replacing <&gmac0> and <&gmac1>
with &gmac0 and &gmac1 respectively so aliases (ethernet0, ethernet1, mmc0,
serial0) consistently use direct phandle references to gmac0, gmac1, sdmmc, and
uart0.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: fffa789e-5cfc-4e20-a7d0-e467bceec802
📒 Files selected for processing (4)
config/boards/ebyte-ecb41-pge.cscpatch/u-boot/u-boot-rk3506/defconfig/ebyte-ecb41-pge_defconfigpatch/u-boot/u-boot-rk3506/dt/rk3506g-ebyte-ecb41-pge-u-boot.dtsipatch/u-boot/u-boot-rk3506/dt/rk3506g-ebyte-ecb41-pge.dts
Description
Adds new RK3506G CSC board EByte ECB41-PGE.
This PR also includes uboot patches (dts/defconfig) to enable this board.
Depends on:
How Has This Been Tested?
./compile.sh BOARD=ebyte-ecb41-pge BRANCH=vendor KERNEL_CONFIGURE=no DEB_COMPRESS=xz KERNEL_BTF=yes INSTALL_ARMBIAN_FIRMWARE=no BUILD_DESKTOP=no BUILD_MINIMAL=yes RELEASE=trixie./compile.sh BOARD=ebyte-ecb41-pge BRANCH=vendor KERNEL_CONFIGURE=no DEB_COMPRESS=xz KERNEL_BTF=yes INSTALL_ARMBIAN_FIRMWARE=no BUILD_DESKTOP=no BUILD_MINIMAL=yes RELEASE=nobleChecklist:
Summary by CodeRabbit