uefi-common: install firmware-sof-signed on every UEFI build#9856
uefi-common: install firmware-sof-signed on every UEFI build#9856igorpecovnik wants to merge 1 commit into
Conversation
UEFI boards are predominantly x86 laptops where audio routes through SOF. Without the firmware blobs the kernel SOF driver probes, fails to load /lib/firmware/intel/sof-ipc4/<plat>/sof-<plat>.ri, and the internal speakers / analog path stays silent (HDMI still works, but that's a fallback most users don't notice until they unplug). Pairs with the cli/amd64 cleanup (#9855) that drops the same package from the per-release CLI baseline. The right home for a desktop-/ laptop-leaning firmware package is the UEFI family include, not the CLI/amd64 per-release packages files. Architecture: all package, so adding it unconditionally for arm64 UEFI is cheap (~7 MB of unused blobs on hosts that don't have an Intel/AMD SOF DSP) and avoids gating the line by LINUXFAMILY here.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Disabled knowledge base sources:
📝 WalkthroughWalkthroughThis change adds a documentation comment and an unconditional call to include the ChangesUEFI SOF Firmware Configuration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Merging with #9855 into a single PR. |
UEFI boards are predominantly x86 laptops where audio routes through SOF. Without the firmware blobs the kernel SOF driver probes, fails to load `/lib/firmware/intel/sof-ipc4//sof-.ri`, and the internal speakers / analog path stays silent (HDMI still works — many users don't notice until they unplug).
Move `firmware-sof-signed` from the per-release CLI baseline to the UEFI family include — that's the right home for a desktop-/laptop-leaning firmware package.
Pairs with
Why unconditional (not gated on `LINUXFAMILY=x86`)
`firmware-sof-signed` is `Architecture: all` — same .deb on every arch, ~7 MB of blobs. Adding it for arm64 UEFI as well is cheap and keeps the file simpler.
Test plan
Summary by CodeRabbit
Release Notes