Skip to content

uefi-common: install firmware-sof-signed on every UEFI build#9856

Closed
igorpecovnik wants to merge 1 commit into
mainfrom
uefi-common-add-firmware-sof-signed
Closed

uefi-common: install firmware-sof-signed on every UEFI build#9856
igorpecovnik wants to merge 1 commit into
mainfrom
uefi-common-add-firmware-sof-signed

Conversation

@igorpecovnik

@igorpecovnik igorpecovnik commented May 18, 2026

Copy link
Copy Markdown
Member

UEFI boards are predominantly x86 laptops where audio routes through SOF. Without the firmware blobs the kernel SOF driver probes, fails to load `/lib/firmware/intel/sof-ipc4//sof-.ri`, and the internal speakers / analog path stays silent (HDMI still works — many users don't notice until they unplug).

Move `firmware-sof-signed` from the per-release CLI baseline to the UEFI family include — that's the right home for a desktop-/laptop-leaning firmware package.

Pairs with

  • cli/amd64: drop firmware-sof-signed from trixie + sid #9855 — drops `firmware-sof-signed` from `config/optional/architectures/amd64/_config/cli/{trixie,sid}/main/packages`. After both merge, the package is shipped on UEFI builds (covers most of the population that needs it) but no longer pulled into non-UEFI / SBC CLI/amd64 images.

Why unconditional (not gated on `LINUXFAMILY=x86`)

`firmware-sof-signed` is `Architecture: all` — same .deb on every arch, ~7 MB of blobs. Adding it for arm64 UEFI as well is cheap and keeps the file simpler.

Test plan

  • Build a UEFI x86 image — `dpkg -l firmware-sof-signed` shows installed; `ls /lib/firmware/intel/sof-ipc4/lnl/` is non-empty
  • Boot on a Lunar Lake / Meteor Lake laptop — `dmesg | grep -i sof` no longer reports "Direct firmware load … failed"; `aplay -l` lists the SOF card
  • Build a UEFI arm64 image — no apt error (package is arch-all and resolves cleanly)

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated UEFI firmware configuration to ensure the signed Intel Sound Open Firmware (SOF) DSP package is included in all builds, improving system compatibility and stability.

Review Change Stack

UEFI boards are predominantly x86 laptops where audio routes through
SOF. Without the firmware blobs the kernel SOF driver probes, fails
to load /lib/firmware/intel/sof-ipc4/<plat>/sof-<plat>.ri, and the
internal speakers / analog path stays silent (HDMI still works, but
that's a fallback most users don't notice until they unplug).

Pairs with the cli/amd64 cleanup (#9855) that drops the same package
from the per-release CLI baseline. The right home for a desktop-/
laptop-leaning firmware package is the UEFI family include, not the
CLI/amd64 per-release packages files.

Architecture: all package, so adding it unconditionally for arm64
UEFI is cheap (~7 MB of unused blobs on hosts that don't have an
Intel/AMD SOF DSP) and avoids gating the line by LINUXFAMILY here.
@coderabbitai

coderabbitai Bot commented May 18, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d1a4c54f-d067-4760-b570-a89373677dd6

📥 Commits

Reviewing files that changed from the base of the PR and between 18bf7ae and 9f620ee.

📒 Files selected for processing (1)
  • config/sources/families/include/uefi_common.inc

Disabled knowledge base sources:

  • Jira integration is disabled

You can enable these sources in your CodeRabbit configuration.


📝 Walkthrough

Walkthrough

This change adds a documentation comment and an unconditional call to include the firmware-sof-signed package in UEFI images via uefi_common.inc.

Changes

UEFI SOF Firmware Configuration

Layer / File(s) Summary
Intel SOF firmware package addition
config/sources/families/include/uefi_common.inc
Adds a comment block documenting Intel SOF DSP firmware usage and an add_packages_to_image firmware-sof-signed call so signed SOF firmware blobs are included in UEFI images.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • armbian/build#9846: Adds the firmware-sof-signed package to the UEFI common image related to enabling Intel SOF kernel modules.

Suggested reviewers

  • rpardini

Poem

🐰 I nudged a line into the boot-time song,
where DSP dreams hum loud and strong.
A signed blob tucked into the frame,
UEFI wakes to Intel's name.
Hop, patch, and listen — all systems belong.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch uefi-common-add-firmware-sof-signed

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size/small PR with less then 50 lines 05 Milestone: Second quarter release Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels May 18, 2026
@igorpecovnik

Copy link
Copy Markdown
Member Author

Merging with #9855 into a single PR.

@igorpecovnik igorpecovnik deleted the uefi-common-add-firmware-sof-signed branch May 18, 2026 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

05 Milestone: Second quarter release Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

1 participant