Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media: i2c: ov5640: add Rockchip-specific support #316

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

bmx666
Copy link
Contributor

@bmx666 bmx666 commented Jan 9, 2025

Rockchip extends the base driver with vendor-specific requirements:

  • Add private ioctl call RKMODULE_GET_MODULE_INFO
  • Implement specific V4L2 callbacks: g_input_status, get_mbus_config
  • Read vendor-specific camera module information from device tree
  • Hardcoded number of MIPI-CSI2 lanes to 2
  • Use old version of probe instead of probe_new

Rockchip extends the base driver with vendor-specific requirements:
- Add private ioctl call RKMODULE_GET_MODULE_INFO
- Implement specific V4L2 callbacks: g_input_status, get_mbus_config
- Read vendor-specific camera module information from device tree
- Hardcoded number of MIPI-CSI2 lanes to 2
- Use old version of probe instead of probe_new
@bmx666
Copy link
Contributor Author

bmx666 commented Jan 9, 2025

I did a quick check by capturing few test patterns, but I will wait the final confirmation from customers by EOD tomorrow.

output_YUYV.mp4

@bmx666
Copy link
Contributor Author

bmx666 commented Jan 9, 2025

And it works as build-in kernel config CONFIG_VIDEO_OV5640=y, I didn't get any success to run camera as kernel module ov5640.ko

@bmx666
Copy link
Contributor Author

bmx666 commented Jan 9, 2025

something mixed in colorspace UYVY is should be converted as uyvy422, but I get correct color with yuyv422.

v4l2-ctl -d /dev/video0 --set-fmt-video=width=640,height=480,pixelformat=UYVY --stream-mmap --stream-count=60 --stream-to=capture_uyvy.raw

ffmpeg -f rawvideo -pix_fmt yuyv422 -s:v 640x480 -i capture_uyvy.raw -c:v libx264 -preset medium -crf 23 output.mp4

@bmx666
Copy link
Contributor Author

bmx666 commented Jan 10, 2025

I did a quick check by capturing few test patterns, but I will wait the final confirmation from customers by EOD tomorrow.

Got confirmation, everything works fine.

@amazingfate amazingfate merged commit 93d3638 into armbian:rk-6.1-rkr4.1 Jan 16, 2025
1 check passed
@bmx666 bmx666 deleted the rk-6.1-rkr4.1-ov5640 branch January 16, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants