Skip to content

net: stmmac: don't put an absent MDIO reset GPIO #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sormy wants to merge 1 commit into
base: rk-6.1-rkr5.1
Choose a base branch
from
Open

net: stmmac: don't put an absent MDIO reset GPIO #524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,8 @@ int stmmac_mdio_idle(struct mii_bus *bus)
if (IS_ERR(reset_gpio))
return PTR_ERR(reset_gpio);

devm_gpiod_put(priv->device, reset_gpio);
if (reset_gpio)
devm_gpiod_put(priv->device, reset_gpio);
}
#endif
#endif
Expand Down Expand Up @@ -405,7 +406,8 @@ int stmmac_mdio_reset(struct mii_bus *bus)
msleep(DIV_ROUND_UP(delays[2], 1000));

/* put reset gpio resource for next time */
devm_gpiod_put(priv->device, reset_gpio);
if (reset_gpio)
devm_gpiod_put(priv->device, reset_gpio);
}
#endif

Expand Down