Fix channels being skipped while scanning#537
Open
superkd13 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
While scanning a scanlist in some configurations, the channel number 0 (M1) in memory is skipped.
Hard to explain, but it is probably related to a read outside the intended range : the arrays gEeprom.SCANLIST_PRIORITY_CH1/2 are of size 3 (so index 0, 1, 2 are readable), but when scanList == 0 or 4, we read index 255 and index 3, which may return the 0 value, skipping channel 0. Please read comments in the commit for more info.
In my case, the PMR01 channel lies on memory location 0 (M1), in scanList 0 (PMR01->PMR16), and is always skipped.
Thanks in advance.