Open
Conversation
|
I just ran into the minio crashbackloop, did these changes and it fixed it on my side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a cherry-pick of the commits from the master branch to the minnaker branch. It fixes minio in minnaker, see: armory/minnaker#99
Not sure if this PR actually is the right way to do this, given that a rebase of the branch to the current master would contain these fixes anyway. However, the branch has its own patches applied to an older state, and I am not sure if someone would be up to rebase these patches to the current master... And since I cannot get minnaker quite running without issues yet, I cannot do it myself ;)
I guess for a quick fix this would suffice. These commits can be easily dropped whenever someone rebases the patches.
Otherwise, don't merge just take this PR as a reminder that the branch has to be fixed.