Support building both amd64 and arm64 docker images #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Build failed on "Login to docker registry", because it's forked repository. @ichi0915 could you help here? Also I see that integration tests were failing for last few merges to master, so it will probably fail on my MR too. |
- docker buildx doesn't allow to easily separate build and push step so `make docker-package` and `make docker-push` needed to be merged into one command - Using locally built image in FROM directive seems impossible with `docker buildx` - remote docker registry is required. So all dockerfiles were merged into one. See: docker/buildx#301 (comment) - AWS_AIM_AUTHENTICATOR_VERSION and GOOGLE_CLOUD_SDK_VERSION were bumped to versions where arm64 binaries are available
Contributor
|
Yeah it is failing because it is a fork we are going to work on that after we fix the integration tests. The other day I tested this PR and it didn't do the push to docker I just saw that you updated the makefile and it looks good, I'm going to do some more test with the newer changes. FYI I cannot merge these changes because I don't have permissions to merge until the actions have passed, I'm going to tell someone in armory to merge this but first we are merging this other PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker buildx doesn't allow to easily separate build and push step
so
make docker-packageandmake docker-pushneeded to be mergedinto one command
Using locally built image in FROM directive seems impossible
with
docker buildx- remote docker registry is required.So all dockerfiles were merged into one.
See: how to buid image using base image on local repo docker/buildx#301 (comment)
AWS_AIM_AUTHENTICATOR_VERSION and GOOGLE_CLOUD_SDK_VERSION were bumped
to versions where arm64 binaries are available