refactor: harden integration infrastructure and professionalize static analysis for v1.4.0#245
Merged
Merged
Conversation
- Add test_modular_assembly.py for namespace prefixing and collision validation. - Add test_fidelity_roundtrip.py for lossless URDF serialization. - Replace flaky Blender concurrency test with reliable rapid collection cleanup stress test. - Fix URDFParser data loss when <sensor> and physics data coexist in the same <gazebo> tag. - Fix type checker NoneType warnings across tests by adding type guards and using strict APIs. - Fix AsynchronousRobotBuilder context sensitivity by tracking active scene. Signed-off-by: arounamounchili <patouossa.mounchili@gmail.com>
- Stabilize Blender integration tests by hardening mock_bpy_env with robust geometric logic. - Implement Ros2ControlSensor model and URDF parsing support for full schema compliance. - Harden XACRO parser by replacing silent failures for missing dependencies with explicit exceptions. - Clean up technical debt across the test suite, including ambiguous variables and brittle comments. - Achieve 100% test pass rate (678 tests) with full lint/type safety compliance. Signed-off-by: arounamounchili <patouossa.mounchili@gmail.com>
- Moved platform-specific pyright suppressions to pyproject.toml - Removed global type-checking ignores from source files - Replaced global ignores with targeted line-level ignores where unavoidable - Hardened primitive detection and async builder logic - Verified 100% pass rate for unit and integration tests Signed-off-by: arounamounchili <patouossa.mounchili@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Important
This project uses Conventional Commits and Release Please for automated versioning.
Please ensure your PR title follows the Conventional Commits format (e.g.,
feat: add lidar sensor,fix: core logic bug).📝 Description
This PR stabilizes the LinkForge v1.4.0 codebase by resolving long-standing technical debt, hardening the integration testing infrastructure, and implementing a more professional static analysis strategy. It ensures the repository meets
🛠️ Type of change
✅ Checklist
uv run pytestand all tests passuv run pre-commit run --all-filesand all hooks pass