Skip to content

ARQ-918 Add @ExcludedServices as extensible substitute for @Deployment(testable = false)#33

Open
mojavelinux wants to merge 2 commits into
arquillian:mainfrom
mojavelinux:ARQ-918
Open

ARQ-918 Add @ExcludedServices as extensible substitute for @Deployment(testable = false)#33
mojavelinux wants to merge 2 commits into
arquillian:mainfrom
mojavelinux:ARQ-918

Conversation

@mojavelinux
Copy link
Copy Markdown
Member

This pull request builds on ARQ-917 since it's necessary to make the changes for both deployment methods and fields.

  • Add @ExcludeServices as an extensible substitute for @deployment(testable=false)
  • Add ServiceType constants to define built-in service groups
  • Write tests for @ExcludeServices on deployment method and field
  • Add field target element for @OperatesOnDeployment and @ShouldThrowException
  • Write missing tests for deployment defined on field

@arjantijms
Copy link
Copy Markdown
Contributor

@mojavelinux "@ExcludedServices" sounds better than what we currently have. Alternatively maybe an extra attribute on "@deployment", e.g. @deployment(excludedServices=...) could work too?

WDYT?

@mojavelinux
Copy link
Copy Markdown
Member Author

I trust you judgmenton this. I haven't looked at it in years.

@starksm64
Copy link
Copy Markdown
Member

I added a new issue to revisit this since this is so old and needs to be integrated with many changes.
#757

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants