Issue 117 part1#129
Open
haster wants to merge 3 commits into
Open
Conversation
Registers a ResourceProvider so tests can inject the registry via @ArquillianResource TestcontainerRegistry and call lookup(String) or lookup(String, Class<T>) directly. TestcontainerRegistry is promoted to public API; iteration responsibilities move inside it as startManaged() and stopAll(), removing the Iterable exposure and inlining TestcontainerDescription as a private nested class. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
ContainerEventTest iterates the shared TestcontainerEventObserver list without filtering by source. Without this clearing, adding any new test class with @TestContainer can leak start events that break ContainerEventTest's per-event assertions — a latent ordering dependency on filesystem-determined test class order. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds coverage for the null/empty-name guard in lookup(String), the missing-name path through the typed lookup(String, Class<T>), and the IllegalArgumentException raised when the requested type does not match the registered container's runtime type. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements feature C4 of #117
Adds @ArquillianResource support for TestcontainerRegistry, including support for programmatic lookups of injected/running containers. This enables glue code to interact with these containers (for example, looking up their ip-addresses).