Skip to content

Change error handling for Exact #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ustitc wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Change error handling for Exact #31

ustitc wants to merge 2 commits into from

Conversation

@ustitc
Copy link
Collaborator

@ustitc ustitc commented Jun 20, 2023 •
edited
Loading

The change is a follow-up of this message #25 (comment)

  • Added ensure(condition: Boolean, lazyMessage: () -> String) function
  • Renamed ExactError to ErrorMessage
  • Replaced most of the examples in doc to by Exact({}) instead of inheritance

ILIYANGERMANOV
ILIYANGERMANOV approved these changes Jun 20, 2023
View reviewed changes
Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CLOVIS-AI
CLOVIS-AI approved these changes Jun 21, 2023
View reviewed changes
Copy link

@CLOVIS-AI CLOVIS-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ustitc ustitc requested review from CLOVIS-AI and removed request for nomisRev July 3, 2023 05:13
@ustitc ustitc requested a review from nomisRev July 4, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ILIYANGERMANOV ILIYANGERMANOV ILIYANGERMANOV approved these changes

@nomisRev nomisRev Awaiting requested review from nomisRev

+1 more reviewer

@CLOVIS-AI CLOVIS-AI CLOVIS-AI approved these changes

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ustitc @ILIYANGERMANOV @CLOVIS-AI