-
Notifications
You must be signed in to change notification settings - Fork 454
Use new kotlin.concurrent.atomics
#3600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I don't think we should choose to keep API compatibility and make a wrapper class around k.c.a impl. We should follow kotlin stdlib API shape and create a new module like arrow.atomics2 while keeping package name. Moreover a wrapper class do harm performance. |
I think this is actually what we should do to keep our API compatible while at the same time making our maintenance work much less (instead of keeping 4 versions of the code, the new one just wraps the common one).
I think the difference in this case (just one more indirection) is quite minimal, to be honest. Even more so because in almost every platform (except JVM) we may get a more performant implementation from Kotlin Team. |
Just trying, maybe we should only merge once this is out of experimental