Cleanup Nec tests#3840
Open
kyay10 wants to merge 7 commits into
Open
Conversation
Contributor
Kover Report
|
serras
reviewed
Jan 10, 2026
serras
left a comment
serras
left a comment
Member
There was a problem hiding this comment.
I really like the simplifications with Arb.nonEmptyList in general. However, in other changes I feel that you introduce non-trivial changes to the code, and this is a tricky business with tests -- we need to test in the most straightforward way possible.
Collaborator
Author
|
Thanks for the nudges in the right direction! The changes are even clearer as a result |
serras
reviewed
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.