Fix _TIMESTAMP_RE to match single-digit timestamps#1248
Open
bysiber wants to merge 1 commit intoarrow-py:masterfrom
Open
Fix _TIMESTAMP_RE to match single-digit timestamps#1248bysiber wants to merge 1 commit intoarrow-py:masterfrom
bysiber wants to merge 1 commit intoarrow-py:masterfrom
Conversation
The regex \d+\.?\d+ requires at least one digit on each side of the optional decimal point. For single-digit values like "0" or "1", the first \d+ consumes the only digit and the second \d+ fails to match anything. Change the trailing \d+ to \d* so the decimal part is fully optional, allowing single-digit timestamps like epoch 0 to be parsed with the X format token.
9d4a22f to
5172a88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
_TIMESTAMP_REto correctly match single-digit timestamps like epoch0.Problem
The current regex pattern is:
This requires
\d+(one or more digits) on both sides of the optional decimal point. For single-digit values:\d+greedily matches the only digit\.?optionally matches nothing\d+requires at least one more digit, but input is exhausted → no matchThis means
arrow.get("0", "X")raisesParserMatchErrorinstead of parsing epoch 0.Fix
Change the trailing
\d+to\d*so the fractional part is fully optional: