Fix type hints for interval and span_range to accept Arrow objects#1262
Open
wavebyrd wants to merge 1 commit intoarrow-py:masterfrom
Open
Fix type hints for interval and span_range to accept Arrow objects#1262wavebyrd wants to merge 1 commit intoarrow-py:masterfrom
wavebyrd wants to merge 1 commit intoarrow-py:masterfrom
Conversation
Updates the type hints for start and end parameters in Arrow.interval() and Arrow.span_range() to Union["Arrow", dt_datetime] to match the documented behavior and be consistent with Arrow.range(). Fixes arrow-py#1210 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1262 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 2315 2315
Branches 358 358
=========================================
Hits 2315 2315 ☔ View full report in Codecov by Sentry. |
Author
|
Ping on this fold kwarg addition for DST disambiguation. Let me know if any changes needed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
startandendparameters inArrow.interval()andArrow.span_range()toUnion["Arrow", dt_datetime]Arrow.range()which already has the correct type hintsChanges
Arrow.interval(): Changedstartandendfromdt_datetimetoUnion["Arrow", dt_datetime]Arrow.span_range(): Changedstartandendfromdt_datetimetoUnion["Arrow", dt_datetime]Test plan
Fixes #1210
🤖 Generated with Claude Code