Add --aws-domain option to ec2-metadata to get the top level service domain name #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziggythehamster
requested review from
tatthurs and
geyermar
and removed request for
a team
johvet
previously approved these changes
Dec 17, 2024
|
FYI I am aware of the conflict. I will fix that in a separate branch so that this one can be safely proposed upstream. |
geyermar
approved these changes
Dec 17, 2024
| @@ -23,6 +23,7 @@ Options: | |||
| -l/--ami-launch-index The index of this instance in the reservation (per AMI). | |||
| -m/--ami-manifest-path The manifest path of the AMI with which the instance was launched. | |||
| -n/--ancestor-ami-ids The AMI IDs of any instances that were rebundled to create this AMI. | |||
| -D/--aws-domain The root domain name that AWS uses in this region | |||
There was a problem hiding this comment.
From a naming convention perspective, what made you choose to prefix with aws-?
|
Proposed as amazonlinux#42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.