add ci testing and update publishing instructions #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatthurs
force-pushed
the
tatthurs/publishing-updates
branch
5 times, most recently
from
5f8f140 to
ed41b5b
Compare
tatthurs
changed the title
tatthurs
force-pushed
the
tatthurs/publishing-updates
branch
from
ed41b5b to
4d3f45d
Compare
tatthurs
commented
Jul 2, 2024
tatthurs
force-pushed
the
tatthurs/publishing-updates
branch
from
6eda3eb to
8744103
Compare
tatthurs
force-pushed
the
tatthurs/publishing-updates
branch
from
8744103 to
92036e2
Compare
lexahu
reviewed
Jul 3, 2024
.github/workflows/ci.yml
Outdated
| - name: Run bundle install | ||
| run: | | ||
| bundle install | ||
| - uses: actions/checkout@v2 |
There was a problem hiding this comment.
Why is this downgraded from actions/checkout@v3 to actions/checkout@v2?
There was a problem hiding this comment.
copy paste -- updated to latest (v4)
.github/workflows/ci.yml
Outdated
| - run: | | ||
| bundle exec rake spec | ||
| env: | ||
| RAILS_ENV: test |
There was a problem hiding this comment.
good catch -- copy paste, removed.
rortian
approved these changes
Jul 16, 2024
| task publish: :build do | ||
| # Requires local setup of personal access token, see: | ||
| # 1. https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-rubygems-registry#authenticating-with-a-personal-access-token | ||
| system("gem push --key github --host https://rubygems.pkg.github.com/art19 " \ |
There was a problem hiding this comment.
stupid nitty: I like multiline quote styles over this
lexahu
approved these changes
Jul 16, 2024
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| ruby: [2.4, 2.7, '3.0', 3.1, 3.2, truffleruby-head] | ||
|
|
||
| ruby: ["2.7", "3.0", "3.1", "3.2", "3.3"] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.