Fix format-related Typesense report errors (#342) #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcantelon
force-pushed
the
dev/formats-count-fix
branch
3 times, most recently
from
5618f1a to
a481446
Compare
mcantelon
changed the title
mcantelon
force-pushed
the
dev/formats-count-fix
branch
from
a481446 to
7e910d2
Compare
mcantelon
force-pushed
the
dev/formats-count-fix
branch
from
eb9153f to
53ffa83
Compare
mcantelon
force-pushed
the
dev/formats-count-fix
branch
6 times, most recently
from
baddb45 to
0dc2d5b
Compare
Don't bother doing a counts of formats, and format versions, of files matching report criteria if no formats, or format versions, were found (given that otherwise a multi-search Typesense query will be sent with no searches and will result in an HTTP 500 error).
mcantelon
force-pushed
the
dev/formats-count-fix
branch
from
0dc2d5b to
c0cdce5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't bother doing a counts of formats, and format versions, of files matching report criteria if no formats, or format versions, were found (given that otherwise a multi-search Typesense query will be sent with no searches and will result in an HTTP 500 error).