Drop SQLite support #405
Merged
Drop SQLite support #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevein
force-pushed
the
dev/only-mysql
branch
3 times, most recently
from
960414a to
5f0434f
Compare
sevein
force-pushed
the
dev/only-mysql
branch
from
5f0434f to
64e33ed
Compare
sevein
force-pushed
the
dev/only-mysql
branch
from
64e33ed to
a38beb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to simplify things, this pull request removes SQLite support so we can focus solely on MySQL. This allows us to avoid testing multiple permutations, reduces the gap between our tests and real-world conditions, simplifies CI, and removes the need for introducing dialects in our models. It also doesn't make much sense to keep SQLite support given that we rely on concurrent writes, i.e. while we could handle this at the application level by adding retry logic, it doesn't make much sense to do so.
In future pull requests, we’ll be looking at bringing database migrations into the project.