Conversation
Drop the standalone Tilt and Kubernetes development environment and keep only the child workflow resources needed to run this template through Enduro's dev env. Flatten the Kubernetes manifests into a single kustomize root, update the README to describe the template as a base for multiple child workflow patterns, and replace the Tilt CI workflow with manifest and Tiltfile validation.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
=======================================
Coverage 45.57% 45.57%
=======================================
Files 6 6
Lines 226 226
=======================================
Hits 103 103
Misses 121 121
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Based on your review from artefactual-sdps/preprocessing-sfa#195 and artefactual-sdps/cva-enduro-workflows#31, I'll merge this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the standalone Tilt and Kubernetes development environment and keep only the child workflow resources needed to run this template through Enduro's dev env. Flatten the Kubernetes manifests into a single kustomize root, update the README to describe the template as a base for multiple child workflow patterns, and replace the Tilt CI workflow with manifest and Tiltfile validation.