Skip to content

Remove duplicate AIS activity registration#134

Merged
djjuhasz merged 1 commit intomainfrom
dev/single-register-activities
Mar 24, 2025
Merged

Remove duplicate AIS activity registration#134
djjuhasz merged 1 commit intomainfrom
dev/single-register-activities

Conversation

@djjuhasz
Copy link
Copy Markdown
Contributor

Use the AIS RegisterActivities() function to register activities in the AIS workflow code and tests.

@djjuhasz djjuhasz force-pushed the dev/single-register-activities branch from 4ac0551 to c2a84ae Compare March 14, 2025 02:51
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 47.05882% with 9 lines in your changes missing coverage. Please review.

Project coverage is 61.47%. Comparing base (cae2ab3) to head (90e395e).

Files with missing lines Patch % Lines
cmd/worker/aiscmd/cmd.go 0.00% 6 Missing ⚠️
internal/ais/workflow.go 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
+ Coverage   60.51%   61.47%   +0.96%     
==========================================
  Files          39       39              
  Lines        2659     2658       -1     
==========================================
+ Hits         1609     1634      +25     
+ Misses        922      896      -26     
  Partials      128      128              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djjuhasz djjuhasz force-pushed the dev/single-register-activities branch from c2a84ae to 90e395e Compare March 14, 2025 03:19
Copy link
Copy Markdown
Contributor

@jraddaoui jraddaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Use the AIS `RegisterActivities()` function to register activities in
the AIS workflow code and tests.

[skip-codecov]
@djjuhasz djjuhasz force-pushed the dev/single-register-activities branch from 90e395e to 173dc6d Compare March 24, 2025 16:27
@djjuhasz djjuhasz merged commit 20c2431 into main Mar 24, 2025
7 checks passed
@djjuhasz djjuhasz deleted the dev/single-register-activities branch March 24, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants