Skip to content

Don't add inapplicable veraPDF PREMIS events (#122)#136

Merged
mcantelon merged 1 commit intomainfrom
dev/validator-dependency-injection
Mar 29, 2025
Merged

Don't add inapplicable veraPDF PREMIS events (#122)#136
mcantelon merged 1 commit intomainfrom
dev/validator-dependency-injection

Conversation

@mcantelon
Copy link
Copy Markdown
Contributor

@mcantelon mcantelon commented Mar 24, 2025

File validators only check certain types of files. Added activity to only add PREMIS events for files that have actually been checked by a validator.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 26 lines in your changes missing coverage. Please review.

Project coverage is 61.32%. Comparing base (fd3c9b8) to head (79ae6ea).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/fformat/fformat.go 50.00% 7 Missing and 5 partials ⚠️
internal/activities/add_premis_validation_event.go 80.85% 6 Missing and 3 partials ⚠️
cmd/worker/workercmd/cmd.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
- Coverage   61.97%   61.32%   -0.66%     
==========================================
  Files          40       42       +2     
  Lines        2759     2818      +59     
==========================================
+ Hits         1710     1728      +18     
- Misses        916      949      +33     
- Partials      133      141       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcantelon mcantelon force-pushed the dev/validator-dependency-injection branch 12 times, most recently from 65ca65a to 81633e1 Compare March 26, 2025 05:02
@mcantelon mcantelon changed the title WIP: Validation-specific PREMIS event activity Don't add inapplicable veraPDF PREMIS events (#122) Mar 26, 2025
Copy link
Copy Markdown
Contributor

@jraddaoui jraddaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Mike!

We should start thinking about updating the PREMIS file from within the activities generating the events, it seems really inefficient to identify all files multiple times across the workflow.

@mcantelon
Copy link
Copy Markdown
Contributor Author

Thanks @jraddaoui !

Yeah, good point!

@mcantelon mcantelon force-pushed the dev/validator-dependency-injection branch from 81633e1 to e6c488b Compare March 29, 2025 08:04
File validators only check certain types of files. Added activity to
only add PREMIS events for files that have actually been checked by a
validator.
@mcantelon mcantelon force-pushed the dev/validator-dependency-injection branch from d28e1e6 to 79ae6ea Compare March 29, 2025 08:20
@mcantelon mcantelon merged commit 252f278 into main Mar 29, 2025
9 checks passed
@mcantelon mcantelon deleted the dev/validator-dependency-injection branch March 29, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants