Don't add inapplicable veraPDF PREMIS events (#122)#136
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
==========================================
- Coverage 61.97% 61.32% -0.66%
==========================================
Files 40 42 +2
Lines 2759 2818 +59
==========================================
+ Hits 1710 1728 +18
- Misses 916 949 +33
- Partials 133 141 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
65ca65a to
81633e1
Compare
jraddaoui
approved these changes
Mar 28, 2025
Contributor
jraddaoui
left a comment
There was a problem hiding this comment.
LGTM, thanks Mike!
We should start thinking about updating the PREMIS file from within the activities generating the events, it seems really inefficient to identify all files multiple times across the workflow.
Contributor
Author
|
Thanks @jraddaoui ! Yeah, good point! |
81633e1 to
e6c488b
Compare
File validators only check certain types of files. Added activity to only add PREMIS events for files that have actually been checked by a validator.
d28e1e6 to
79ae6ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File validators only check certain types of files. Added activity to only add PREMIS events for files that have actually been checked by a validator.