Skip to content

Reduce APIS pollInterval values in dev#190

Merged
djjuhasz merged 1 commit intomainfrom
dev/reduce-kube-apis-pollintervals
Apr 11, 2026
Merged

Reduce APIS pollInterval values in dev#190
djjuhasz merged 1 commit intomainfrom
dev/reduce-kube-apis-pollintervals

Conversation

@djjuhasz
Copy link
Copy Markdown
Contributor

Reduce APIS pollInterval values from 30s to 1s in the kube overlays to reduce preprocessing workflow run times in development. Because the APIS mock server requires 3 polls to complete analysis this reduces the API poll activity time from ~1m30s to ~3s.

Reduce APIS pollInterval values from 30s to 1s in the kube overlays to
reduce preprocessing workflow run times in development. Because the
APIS mock server requires 3 polls to complete analysis this reduces the
API poll activity time from ~1m30s to ~3s.
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.12%. Comparing base (cde811c) to head (35cc8fb).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   61.12%   61.12%           
=======================================
  Files          47       47           
  Lines        2796     2796           
=======================================
  Hits         1709     1709           
  Misses        940      940           
  Partials      147      147           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djjuhasz djjuhasz requested a review from jraddaoui April 10, 2026 17:23
Copy link
Copy Markdown
Contributor

@jraddaoui jraddaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @djjuhasz! May be tight, even if it's a mocked server, I'd consider setting it to 5 seconds.

@djjuhasz
Copy link
Copy Markdown
Contributor Author

@jraddaoui 1 second worked fine when I tested it. Where do you think that timing might be tight? The mock server is certainly capable of returning a response much faster than 1 second, and I don't think we'll be making a lot of simultaneous requests.

@jraddaoui
Copy link
Copy Markdown
Contributor

Feels safer to me, and it doesn't add a big amount of time as before. We may add extra processing needs to the mock server, add k8s proxies like linkerd, or other changes that could increase response time. Up to you, we can always change it again ;)

@djjuhasz
Copy link
Copy Markdown
Contributor Author

djjuhasz commented Apr 11, 2026

Well, I'm impatient so I'll take the risk in exchange for the preprocessing workflow running 12 seconds faster when I'm doing testing. 😈 I think the worst thing that can happen on a slow response from the mock server is that the activity will poll an extra time or two, I'd only really be concerned if we were piling a lot of requests too fast and DOS'd the mock server.

@djjuhasz djjuhasz merged commit 06ffa89 into main Apr 11, 2026
7 checks passed
@djjuhasz djjuhasz deleted the dev/reduce-kube-apis-pollintervals branch April 11, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants