Conversation
djjuhasz
force-pushed
the
dev/add-xmlvalidate-cmd
branch
from
70eb8c2 to
5605d5d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
=======================================
Coverage 81.88% 81.88%
=======================================
Files 16 16
Lines 436 436
=======================================
Hits 357 357
Misses 55 55
Partials 24 24 ☔ View full report in Codecov by Sentry. |
djjuhasz
force-pushed
the
dev/add-xmlvalidate-cmd
branch
from
5605d5d to
3d926ef
Compare
Add `xmlvalidate/cmd/xmlvalidate.go` to allow running xmlvalidate from the CLI for testing purposes.
djjuhasz
force-pushed
the
dev/add-xmlvalidate-cmd
branch
from
3d926ef to
3d650f4
Compare
| XMLFILE Path of the XML file to be validated | ||
|
|
||
| OPTIONS: | ||
| --xsd PATH Path of an XSD file to validate against |
There was a problem hiding this comment.
Since it's required, I'd make it an argument too.
There was a problem hiding this comment.
I made it an option for two reasons:
- It avoids confusing the order of the XML file path and XSD file path, e.g.
xmlvalidate person.xsd people.xmlvs.xmlvalidate people.xml person.xsd - It leaves open the option of adding a
--dtdoption to validate XML against a DTD file instead of an XSD
I think the first reason justifies typing the extra --xsd .
| } else { | ||
| fmt.Println(out) | ||
| } | ||
| } |
There was a problem hiding this comment.
Recent PRs changed the xmlvalidate activity but didn't reflect those changes in the docs (parameter names, result type, how to use the XMLLintValidator). It would be nice to include a note somewhere in there about this command too, if we really want to include it.
There was a problem hiding this comment.
Oops! I'll update the docs. 😊
| } | ||
|
|
||
| // To test: `go run ./cmd --xsd testdata/person.xsd testdata/person_valid.xml` | ||
| func main() { |
There was a problem hiding this comment.
We should try to follow https://artefactual.dev/docs/programming-languages/go/main/ and add some tests for this command.
2 participants
Add an
xmlvalidatecommand to help testing the functionality from the CLI.