delete source path after moving#634
Open
fitnycdigitalinitiatives wants to merge 1 commit intoartefactual:qa/0.xfrom
Open
delete source path after moving#634fitnycdigitalinitiatives wants to merge 1 commit intoartefactual:qa/0.xfrom
fitnycdigitalinitiatives wants to merge 1 commit intoartefactual:qa/0.xfrom
Conversation
|
I will try to start the tests by closing/re-opening the branch... |
Contributor
|
@fitnycdigitalinitiatives :Thank you for the contribution! Based on the results of the tests, it appears that the linting test failed. Would it be possible for you to fix the linting issue ? There is a pre-commit setup you can create. It should be done pre-commit install inside the git repo. Thanks! |
Contributor
Author
|
Ok, let me see when I can get to this, it's been a while since I worked on this. |
sarah-mason
added
the
Community
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Piggybacking off of #632, even if the pointer file is successfully recreated, I don't think 'move' is working fully as intended because it doesn't delete the original package in the source after the move. Though, I'm not sure if that was the intent to leave the original there. In the SS api, it uses the term 'relocate' so I'm assuming that the intent is to remove the original files in the source. This uses 'delete_path' to do so.