Fix: Preserve related_packages when PUT omits the field#836
Open
thales0591 wants to merge 3 commits intoartefactual:qa/0.xfrom
Open
Fix: Preserve related_packages when PUT omits the field#836thales0591 wants to merge 3 commits intoartefactual:qa/0.xfrom
thales0591 wants to merge 3 commits intoartefactual:qa/0.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: archivematica/Issues#1774
Summary
This PR prevents AIP↔DIP relationships from being unintentionally cleared during reingest. We observed that the DIP is stored with the correct
related_package_uuid, but a later AIP update (PUT) wipesrelated_packagesbecause the field is omitted. The fix preserves existing relationships on PUT whenrelated_packagesis not included.What we observed (logs)
storeaip_v0.0task sendsrelated_package_uuidcorrectly.related_packagespointing to the AIP.Normal ingest flow (works)
related_package_uuid(pipelinestore_aip.py).self.related_packages.add(...)).Reingest flow (problematic)
PackageResource.obj_update→obj_update_hook→finish_reingestrelated_packages.related_packagesis symmetric, the DIP loses the reverse link too.Fix implemented
In
PackageResource.obj_update, if the request is PUT andrelated_packagesis not present, we preserve the current relationships:related_packagesbeforefull_hydrate.Alternatives considered
related_packagesonly during reingest (insidefinish_reingest).