feat: Produce completion items with kind = Reference #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, no kind was provided, which made editors treat these completions like 'Text' completions. The problem with text completions is that they can be disabled by users due to their noise. Which then leads to confusion as to why Marksman's completion doesn't work in neovim or something. Example config recommendation: https://github.com/hrsh7th/nvim-cmp/blob/5dce1b778b85c717f6614e3f4da45e9f19f54435/doc/cmp.txt#L663 Possibly fixes: #204 stack-info: PR: #363, branch: artempyanykh/stack/12
artempyanykh
force-pushed
the
artempyanykh/stack/12
branch
from
94d5575 to
5b66a05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
feat: Produce completion items with kind = Reference
Previously, no kind was provided, which made editors treat these completions like 'Text' completions.
The problem with text completions is that they can be disabled by users due to their noise. Which then leads to confusion as to why Marksman's completion doesn't work in neovim or something.
Example config recommendation: https://github.com/hrsh7th/nvim-cmp/blob/5dce1b778b85c717f6614e3f4da45e9f19f54435/doc/cmp.txt#L663
Possibly fixes: #204