heading ID disambiguation according to GLFM spec #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artempyanykh
requested changes
Jan 15, 2025
Owner
artempyanykh
left a comment
artempyanykh
left a comment
There was a problem hiding this comment.
Thanks for submitting the PR! It looks good. The one I'd change is gating disambiguation logic by a config flag.
Spec: https://docs.gitlab.com/ee/user/markdown.html#heading-ids-and-links GitHub also seems to follow this when generating heading IDs.
komar007
force-pushed
the
ambiguous-headings
branch
from
77b9878 to
dfdb734
Compare
Contributor
Author
|
Done, thanks for your comments. |
artempyanykh
approved these changes
Jan 22, 2025
Owner
artempyanykh
left a comment
artempyanykh
left a comment
There was a problem hiding this comment.
Thanks for the contribution @komar007!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #383.
I don't know F#, please feel free to nitpick.