Fix JsonLd generate() to respect the $minify parameter#392
Open
RohithVangalla1 wants to merge 1 commit into
Open
Fix JsonLd generate() to respect the $minify parameter#392RohithVangalla1 wants to merge 1 commit into
RohithVangalla1 wants to merge 1 commit into
Conversation
The generate() method accepted a $minify parameter but ignored it — JSON-LD output was always minified regardless of the flag value. This change: - When $minify is false (default): outputs pretty-printed JSON-LD with JSON_PRETTY_PRINT for better readability during development - When $minify is true: outputs compact JSON (existing behavior) - Passes $minify through from JsonLdMulti to individual JsonLd instances This aligns JsonLd with the behavior of other generate() methods in the package (OpenGraph, TwitterCards) which also accept $minify.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
generate()method inJsonLdandJsonLdMultiaccepted a$minifyparameterbut completely ignored it — JSON-LD output was always minified.
Fix
JsonLd::generate(): When$minifyis false (default), addsJSON_PRETTY_PRINTflag for readable output during development
JsonLdMulti::generate(): Passes$minifythrough to individualJsonLdinstances(was previously hardcoded without the parameter)
Before