Skip to content

fixing detaching gradients in get_components #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fixing detaching gradients in get_components #3

wants to merge 4 commits into from

Conversation

@tommybotch
Copy link

@tommybotch tommybotch commented Oct 29, 2025

Accessing the components via .data detaches gradients and returns the tensor for all options (even when detach=False).

Updated to remove .data and .detach will now handle removing gradients and returning the tensor

@tommybotch
Copy link
Author

tommybotch commented Oct 29, 2025

Also if not detach was detaching gradients --> commands were backwards. Now changing to if detach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tommybotch