handle multi-responses with socketio on different channels#172
Open
fabong wants to merge 2 commits intoartilleryio:masterfrom
Open
handle multi-responses with socketio on different channels#172fabong wants to merge 2 commits intoartilleryio:masterfrom
fabong wants to merge 2 commits intoartilleryio:masterfrom
Conversation
f68e97e to
0c0f814
Compare
Member
|
Nice. Would it make sense to support a |
Author
|
Yes, you're right, it should be a good feature. I'll implement it next week. |
6e34ca0 to
aa39e6c
Compare
aa39e6c to
8acba11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
In order to have a complete test, I needed to handle multi-responses with socketio on different channels. This pull-request adds the support of it.
Here is some examples of supported configurations :
2 responses sent on different channels :
2 responses sent on the same channel and another one sent on different channel :
In that case, I assume that messages on the same channel should be sent in the same order as defined.
Because it is just an array support of the
responseexisting parameters, it also works with the current configuration as :What do you think about it ?
Thanks in advance,
Fabrice.