Skip to content

Suppress "this-escape" warnings from generated encoders and decoders #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
writeoncereadmany wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Suppress "this-escape" warnings from generated encoders and decoders #533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...o-codecs/src/main/java/uk/co/real_logic/artio/dictionary/generation/DecoderGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,7 @@ private String classDeclaration(
return String.format(
"\n" +
GENERATED_ANNOTATION +
SUPPRESS_THIS_ESCAPE_ANNOTATION +
"public %3$s%4$sclass %1$s extends %5$s%2$s\n" +
"{\n",
className,
Expand Down
2 changes: 2 additions & 0 deletions ...o-codecs/src/main/java/uk/co/real_logic/artio/dictionary/generation/EncoderGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
import static uk.co.real_logic.artio.dictionary.generation.AggregateType.HEADER;
import static uk.co.real_logic.artio.dictionary.generation.EnumGenerator.enumName;
import static uk.co.real_logic.artio.dictionary.generation.GenerationUtil.GENERATED_ANNOTATION;
import static uk.co.real_logic.artio.dictionary.generation.GenerationUtil.SUPPRESS_THIS_ESCAPE_ANNOTATION;
import static uk.co.real_logic.artio.dictionary.generation.GenerationUtil.fileHeader;
import static uk.co.real_logic.artio.dictionary.generation.GenerationUtil.importFor;
import static uk.co.real_logic.artio.dictionary.generation.OptionalSessionFields.ENCODER_OPTIONAL_SESSION_FIELDS;
Expand Down Expand Up @@ -347,6 +348,7 @@ private String classDeclaration(
return String.format(
"\n" +
GENERATED_ANNOTATION +
SUPPRESS_THIS_ESCAPE_ANNOTATION +
"public %3$s%4$sclass %1$s%5$s%2$s\n" +
"{\n",
className,
Expand Down
1 change: 1 addition & 0 deletions artio-codecs/src/main/java/uk/co/real_logic/artio/dictionary/generation/GenerationUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ public final class GenerationUtil

public static final String INDENT = " ";
public static final String GENERATED_ANNOTATION = "@Generated(\"uk.co.real_logic.artio\")\n";
public static final String SUPPRESS_THIS_ESCAPE_ANNOTATION = "@SuppressWarnings(\"this-escape\")\n";

private GenerationUtil()
{
Expand Down