allowing custom float overflow handling #539

lucianoviana · 2025-01-17T15:16:15Z

No description provided.

wojciech-adaptive · 2025-01-20T13:01:59Z

artio-codecs/src/test/java/uk/co/real_logic/artio/fields/DecimalFloatDecodingTest.java

 public class DecimalFloatDecodingTest
 {
+
+    public static final long MAX_ALLOWED_LONG = 999_999_999_999_999_999L;


Maybe make VALUE_MAX_VAL visible instead? At least make this private.

wojciech-adaptive · 2025-01-20T13:16:03Z

.../test/java/uk/co/real_logic/artio/dictionary/generation/FloatOverflowHandlerDecoderTest.java

+        assertFalse(decoder.validate());
+    }
+
+    private void assertPrice(final Object memberIDsGroupDecoder, final Object b) throws Exception


The first parameter name doesn't make sense, the second one could be improved too.

wojciech-adaptive · 2025-01-20T13:16:22Z

.../test/java/uk/co/real_logic/artio/dictionary/generation/FloatOverflowHandlerDecoderTest.java

@@ -0,0 +1,98 @@
+/*
+ * Copyright 2021 Adaptive Financial Consulting Ltd.


Wrong year.

wojciech-adaptive · 2025-01-20T13:16:47Z

.../test/java/uk/co/real_logic/artio/dictionary/generation/FloatOverflowHandlerDecoderTest.java

+import static uk.co.real_logic.artio.dictionary.generation.CodecGenerationWrapper.dictionaryStream;
+import static uk.co.real_logic.artio.util.Reflection.get;
+
+import org.junit.Test;


Please use JUnit 5 for new tests.

wojciech-adaptive · 2025-01-20T13:20:36Z

artio-codecs/src/main/java/uk/co/real_logic/artio/util/AsciiBuffer.java

+    DecimalFloat getFloat(DecimalFloat number,
+        int offset,
+        int length,
+        int tagId,


It's a bit weird that AsciiBuffer takes a tag number.

if I dont do this then there's no way for the tagId to reach the overflow handler.

wojciech-adaptive · 2025-01-20T13:22:54Z

artio-codecs/src/main/java/uk/co/real_logic/artio/dictionary/generation/CodecConfiguration.java

+                {
+                    //noinspection unchecked
+                    decimalFloatOverflowHandler = (Class<? extends DecimalFloatOverflowHandler>)Class.forName(
+                      floatOverflowHandler);


Do you need to actually load that class instead of using a String fqcn?

doing this during codec generation time will fail-fast in case the class name is invalid or it's not reachable.

Which means you need to have in classpath while generating code, compiling the generated code will validate that anyway.

I see - will change this then

wojciech-adaptive · 2025-01-20T13:27:20Z

artio-codecs/src/main/java/uk/co/real_logic/artio/dictionary/generation/DecoderGenerator.java

+            null);
+    }
+
+    DecoderGenerator(


Should we update callers instead of adding a new constructor? It's internal, so that should be simpler.

wojciech-adaptive · 2025-01-20T13:36:42Z

artio-codecs/src/main/java/uk/co/real_logic/artio/util/float_parsing/DecimalFloatParser.java

+        final int dotIndex,
+        final int tagId)
+    {
+        return overflowHandler.handleOverflow(charReader.asString(data, offset, length),


This will allocate a substring, plus the API forces implementations to allocate a DecimalFloat, why not pass the existing objects?

good point - cheers

wojciech-adaptive · 2025-01-20T13:42:05Z

artio-codecs/src/main/java/uk/co/real_logic/artio/util/float_parsing/DecimalFloatParser.java

+        return updateValue(number, workingScale, exponent, timesNeg, negative, value);
+    }
+
+    private static DecimalFloat updateValue(final DecimalFloat number, final int workingScale, final int exponent,


Can you please format consistently, ideally every parameter on its own line if breaking is needed.

artio-codecs/src/test/java/uk/co/real_logic/artio/builder/CommonDecoderImplTest.java

wojciech-adaptive · 2025-01-22T09:08:04Z

...ecs/src/main/java/uk/co/real_logic/artio/util/float_parsing/DecimalFloatOverflowHandler.java

+     * @return instance of DecimalFloat to be use
+     * @param <Data> generic buffer
+     */
+    <Data> DecimalFloat handleOverflow(


That still forces the implementations to allocate the result, why not pass the existing instance in?

I hope it's in a better shape now

wojciech-adaptive · 2025-01-22T09:08:49Z

artio-codecs/src/main/java/uk/co/real_logic/artio/dictionary/generation/CodecConfiguration.java

    }

+    /**
+     * Sets the full qualified class name of a DecimalFloat overflow handler.


Would be good to mention what interface it needs to implement.

artio-codecs/src/test/java/uk/co/real_logic/artio/builder/CommonDecoderImplTest.java

* allowing custom float overflow handling * Upgrade github actions to v4 (cherry picked from commit 69cf6ce)

* allowing custom float overflow handling * Upgrade github actions to v4

lucianoviana requested a review from wojciech-adaptive January 17, 2025 15:36

wojciech-adaptive reviewed Jan 20, 2025

View reviewed changes

lucianoviana force-pushed the luc/hy-52 branch from 907e5ce to 67b0cfb Compare January 20, 2025 14:37

github-advanced-security bot found potential problems Jan 20, 2025

View reviewed changes

lucianoviana force-pushed the luc/hy-52 branch 2 times, most recently from 2aa9924 to 544fe86 Compare January 21, 2025 15:30

wojciech-adaptive reviewed Jan 23, 2025

View reviewed changes

lucianoviana force-pushed the luc/hy-52 branch 5 times, most recently from e26b043 to 7c342c9 Compare January 27, 2025 16:57

github-advanced-security bot found potential problems Jan 27, 2025

View reviewed changes

artio-codecs/src/test/java/uk/co/real_logic/artio/builder/CommonDecoderImplTest.java Fixed Show fixed Hide fixed

lucianoviana force-pushed the luc/hy-52 branch 3 times, most recently from 7d7e229 to 15894c1 Compare January 28, 2025 15:10

lucianoviana added 2 commits January 28, 2025 17:28

allowing custom float overflow handling

05e2880

Upgrade github actions to v4

7c81787

lucianoviana force-pushed the luc/hy-52 branch from 15894c1 to 7c81787 Compare January 28, 2025 16:28

lucianoviana merged commit 69cf6ce into artiofix:master Jan 28, 2025
5 of 6 checks passed

lucianoviana deleted the luc/hy-52 branch January 28, 2025 16:49

lucianoviana added a commit that referenced this pull request Mar 14, 2025

allowing custom float overflow handling (#539)

53e7d7e

* allowing custom float overflow handling * Upgrade github actions to v4 (cherry picked from commit 69cf6ce)

writeoncereadmany pushed a commit to TransFICC/artio that referenced this pull request Oct 13, 2025

allowing custom float overflow handling (artiofix#539)

f8dca36

* allowing custom float overflow handling * Upgrade github actions to v4

		@@ -0,0 +1,98 @@
		/*
		* Copyright 2021 Adaptive Financial Consulting Ltd.

allowing custom float overflow handling #539

allowing custom float overflow handling #539

Uh oh!

Conversation

lucianoviana commented Jan 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants