[Feature] optimize conceal #445
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize the scrolling when conceal is enabled.
Currently the whole concealment array is being recomputed even though nothing has been changed.
The change is not that much from 4-8 ms to <1ms on my machine, but the little things may add up.
There is also currently a bug, where the syntaxtree hasn't been fully computed yet.
To reproduce: Reload page without saving and go bottom with
Gin vim.ensureSyntaxTree(state,to)can be used or we can debounce a view.dispatch when its not available.@llakala do you maybe have any comment?
ensureSyntaxTreedidn't take more than 30ms on my machine even with 22,222 words, butensureSyntaxTreeonly updates a local tree and not the global syntax tree.Also the bug is very minor so idk if its worth the extra complexity.