Do not process resize event if fotorama is hidden #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/js/fotorama.js
Outdated
| if (!data) return this; | ||
|
|
||
| // don't process resize for hidden elements | ||
| if ($wrap.is(':hidden')) return this; |
Resize event recalcs image dimensions in wrong way (see example https://jsfiddle.net/doochik/1mdhtbav/). In this case we should stop processing resize event if fotorama is hidden. As a workaround for this bug we can use `position:abosulte;left:-9990px;top:-9999px` instead of `display: none` to hide fotorama.
doochik
force-pushed
the
fix-hidden-fotorama-resize
branch
from
430f068 to
2d72f8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resize event recalcs image dimensions in wrong way (see example https://jsfiddle.net/doochik/1mdhtbav/).
In this case we should stop processing resize event if fotorama is hidden.
As a workaround for this bug we can use
position:abosulte;left:-9990px;top:-9999pxinstead ofdisplay: noneto hide fotorama.