Skip to content

Conversation

@xander-pero
Copy link
Contributor

@xander-pero xander-pero commented Nov 6, 2025

The type of this PR is: feat

Description

I add clickedHeader event which should be called on the artist page when a user clicks on Artworks, Auction Results, or About. Some notes about the implementation:

  • artistHeader isn't the most descriptive context_module but it already exists, and didn't want to introduce a new one
  • for context_page_owner_type, the experiment group will always fire artist because that's the URL. However, if possible, I'd like the control group to fire artist when they're under Artworks or About, and artistAuctionResults when they're under Auction Results. If this is overly annoying to implement, everything firing artist is alright too; just let me know.
  • The current artist page fires a Click event on these headers. We should deprecate that event and replace it with clickedHeader so that both control and experiment are firing the same event.

PR Checklist (tick all before merging)

  • If I've added a new file to the tree I've exported it from the common index.ts
  • I've added comments with examples for any new interfaces and ensured that they're in the docs
  • No platform-specific terminology has been used outside of click and tap (platform is inferred by the DB storing events)

@xander-pero xander-pero requested a review from dzucconi November 6, 2025 21:01
@xander-pero xander-pero self-assigned this Nov 6, 2025
@artsy-peril artsy-peril bot added Jira Synced Indicates that Peril has connected this PR to Jira Version: Minor A deploy for new features labels Nov 6, 2025
@xander-pero xander-pero merged commit 95b4b90 into main Nov 6, 2025
10 checks passed
@xander-pero xander-pero deleted the xander.unified_artist_page branch November 6, 2025 21:07
@artsyit
Copy link
Collaborator

artsyit commented Nov 6, 2025

🚀 PR was released in v4.318.0 🚀

@xander-pero xander-pero restored the xander.unified_artist_page branch December 1, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Jira Synced Indicates that Peril has connected this PR to Jira released Version: Minor A deploy for new features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants