Skip to content

feat: improved artist page tracking (Diamond) #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xander-pero merged 10 commits into from
Dec 15, 2025
Merged

feat: improved artist page tracking (Diamond) #665

xander-pero merged 10 commits into from
Dec 15, 2025

Conversation

@xander-pero
Copy link
Contributor

@xander-pero xander-pero commented Dec 2, 2025 •
edited
Loading

The type of this PR is: feat

Description

This PR is based on this spreadsheet. Here's what it does:

  • Adds new examples to toggledAccordion, which we're reusing
  • Fixes some old events that weren't firing before, and renamed (clickedCV and clickedGene)
  • Adds toggledArtistBio for toggling an expanded/truncated artist bio
  • Adds new context modules and owner types when necessary
  • This does not add new examples for clickedLoadMore and clickedAuctionResultItem, to be used once unified page is launched

PR Checklist (tick all before merging)

  • If I've added a new file to the tree I've exported it from the common index.ts
  • I've added comments with examples for any new interfaces and ensured that they're in the docs
  • No platform-specific terminology has been used outside of click and tap (platform is inferred by the DB storing events)

@xander-pero xander-pero requested a review from dzucconi December 2, 2025 19:19
@xander-pero xander-pero self-assigned this Dec 2, 2025
@artsy-peril artsy-peril bot added the Jira Synced Indicates that Peril has connected this PR to Jira label Dec 2, 2025
@artsyit artsyit added the Version: Minor A deploy for new features label Dec 2, 2025
@xander-pero xander-pero requested a review from a team December 15, 2025 14:37
@xander-pero xander-pero merged commit 78aae8c into main Dec 15, 2025
14 checks passed
@xander-pero xander-pero deleted the xander.unified_artist_page branch December 15, 2025 17:01
@artsyit
Copy link
Collaborator

artsyit commented Dec 15, 2025

🚀 PR was released in v4.334.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzucconi dzucconi Awaiting requested review from dzucconi

Assignees

@xander-pero xander-pero

Labels

Jira Synced Indicates that Peril has connected this PR to Jira released Version: Minor A deploy for new features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xander-pero @artsyit