Skip to content

Conversation

@dblandin
Copy link
Member

@dblandin dblandin commented Dec 8, 2025

The type of this PR is: Feature

Description

Adds two new events for tracking navigation dropdown interactions:

navigationDropdownViewed - fires when dropdown is displayed

  {
    action: "navigationDropdownViewed",
    context_module: "header",
    context_page_owner_type: "home",
    navigation_item: "Artists",
    interaction_type: "hover"
  }

ClickedNavigationDropdownItem - typed interface for dropdown clicks

  {
    action: "click",
    flow: "Header",
    context_module: "HeaderArtworksDropdown",
    context_page_owner_type: "home",
    parent_navigation_item: "Artworks",
    dropdown_group: "Blue-Chip Artists",
    subject: "Banksy",
    destination_path: "/artist/banksy"
  }

PR Checklist (tick all before merging)

  • If I've added a new file to the tree I've exported it from the common index.ts
  • I've added comments with examples for any new interfaces and ensured that they're in the docs
  • No platform-specific terminology has been used outside of click and tap (platform is inferred by the DB storing events)

@dblandin dblandin self-assigned this Dec 8, 2025
@artsy-peril artsy-peril bot added the Jira Synced Indicates that Peril has connected this PR to Jira label Dec 8, 2025
@artsyit artsyit added the Version: Minor A deploy for new features label Dec 8, 2025
@dorotamierzwa
Copy link

thanks @dblandin !

all good for navigationSubmenuViewed

for clickedNavigationSubmenuItem I see we already track a click event with below properties:

 {
    event: "Click",
    type:"track",
    properties: {
      flow: "Header",
      context_module: "HeaderArtworksDropdown",
      subject: "Red",
      destination_path: "/artist/banksy"
}
  }

would the navigationSubmenuViewed replace it or is it a new version of that click event?

@dblandin
Copy link
Member Author

dblandin commented Dec 9, 2025

@dorotamierzwa Ahh, I missed that existing click event. No, if that's sufficient, we can simplify this PR to introduce only the new viewed event.

Is that what you would recommend?

@dorotamierzwa
Copy link

In that case yes I would say let's not introduce a new event. I do like though the new properties you suggested that are not currently there:

    context_page_owner_type: "home",
    submenu_group: "Blue-Chip Artists"

would it be easy to add those two to the current click?

@dblandin dblandin force-pushed the dblandin/web-nav-submenu-tracking branch from 993bd1a to 13d5858 Compare December 9, 2025 11:26
Adds two new events for tracking navigation dropdown interactions:

navigationDropdownViewed - fires when dropdown is displayed
  {
    action: "navigationDropdownViewed",
    context_module: "header",
    context_page_owner_type: "home",
    navigation_item: "Artists",
    interaction_type: "hover"
  }

ClickedNavigationDropdownItem - typed interface for dropdown clicks
  {
    action: "click",
    flow: "Header",
    context_module: "HeaderArtworksDropdown",
    context_page_owner_type: "home",
    parent_navigation_item: "Artworks",
    dropdown_group: "Blue-Chip Artists",
    subject: "Banksy",
    destination_path: "/artist/banksy"
  }
@dblandin dblandin force-pushed the dblandin/web-nav-submenu-tracking branch from 13d5858 to 199e624 Compare December 9, 2025 11:27
@dblandin dblandin changed the title feat: add navigation submenu tracking events chore: add navigation dropdown tracking events Dec 9, 2025
@dblandin
Copy link
Member Author

dblandin commented Dec 9, 2025

@dorotamierzwa Thanks for the feedback! I just pushed some changes:

  • Renamed navigationSubmenuViewed to navigationDropdownViewed to remain consistent with current terminology.
  • Added a ClickedNavigationDropdownItem event type, which should now be compatible with the current click event but also includes some new properties.

@dblandin dblandin merged commit 25359bf into main Dec 9, 2025
11 checks passed
@dblandin dblandin deleted the dblandin/web-nav-submenu-tracking branch December 9, 2025 11:37
@artsyit
Copy link
Collaborator

artsyit commented Dec 9, 2025

🚀 PR was released in v4.331.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Jira Synced Indicates that Peril has connected this PR to Jira released Version: Minor A deploy for new features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants