feat: add SelectedItemFromSearchPage and enhance SelectedItemFromSearch #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add SelectedItemFromSearchPage interface with item tracking fields - Update SelectedItemFromSearch to include destination_path and item tracking (item_id, item_number, item_type) - Remove deprecated helper (confirmed unused)
artsy-peril
bot
added
the
Jira Synced
Collaborator
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of this PR is: Feature
Description
Surprisingly, the existing SelectedItemFromSearch event type isn't yet used in our clients. This PR updates the event definition to match what we're currently sending and notably adds more item tracking properties to remain consistent with the search results page.
PR Checklist (tick all before merging)
index.tsclickandtap(platform is inferred by the DB storing events)📦 Published PR as canary version:
4.333.0--canary.670.13949.0✨ Test out this PR locally via: