Skip to content

fix(DIA-1314): don't show empty state while Discover Something New collection is loading #12099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

iskounen
Copy link
Contributor

@iskounen iskounen commented May 8, 2025

BEFORE AFTER
https://github.com/user-attachments/assets/e8de90c1-4073-400e-be13-94b1e1f28b36 https://github.com/user-attachments/assets/582ab048-288b-4358-a981-55f5db78e2da

PR Checklist

  • I have tested my changes on the following platforms:
    • Android.
    • iOS.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos at least on Android, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@iskounen iskounen requested a review from araujobarret May 8, 2025 20:28
@iskounen iskounen self-assigned this May 8, 2025
@iskounen iskounen marked this pull request as draft May 8, 2025 20:28
@iskounen iskounen force-pushed the iskounen/fix/discover-something-new-empty-state branch from 1398191 to 8c0702b Compare May 9, 2025 16:09
@iskounen iskounen closed this May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant