-
Notifications
You must be signed in to change notification settings - Fork 594
chore(ff): Update ArrowCircleFill Icons #12143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -18,7 +13,7 @@ export const ReserveNotMet = () => ( | |||
|
|||
export const HighestBid = () => ( | |||
<> | |||
<ArrowUpCircleFillIcon fill="green100" /> | |||
<ArrowheadUpCircleFillIcon height={16} width={16} fill="green100" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had to update the size to 16 to look the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Arrow Circle Fill icons to use the latest Artsy Icons implementation. Key changes include:
- Removing deprecated icon imports and using the new ArrowheadUpCircleFillIcon and ArrowheadDownCircleFillIcon components.
- Setting explicit height and width properties for the new icons.
- Upgrading the @artsy/icons dependency from version 3.30.0 to 3.35.0.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/app/Scenes/MyBids/Components/BiddingStatuses.tsx | Replaced old icon components with updated Artsy Icons components and added explicit sizing props. |
package.json | Updated the @artsy/icons dependency version to incorporate the new icon components. |
Comments suppressed due to low confidence (2)
src/app/Scenes/MyBids/Components/BiddingStatuses.tsx:16
- [nitpick] Verify that the explicit dimensions (height=16 and width=16) for the new ArrowheadUpCircleFillIcon match the design specifications. Ensure consistency in icon sizing throughout the app.
<ArrowheadUpCircleFillIcon height={16} width={16} fill="green100" />
src/app/Scenes/MyBids/Components/BiddingStatuses.tsx:26
- [nitpick] Confirm that setting explicit dimensions for ArrowheadDownCircleFillIcon is intended and consistent with the app's overall icon sizing guidelines.
<ArrowheadDownCircleFillIcon height={16} width={16} fill="red100" />
This PR resolves MOPRAT-840, MOPRAT-841
Description
This PR updates the Arrow__CircleFill Icons to use the Artsy Icons ones
Screenshots
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.