Skip to content

chore(ff): Update ArrowCircleFill Icons #12143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MrSltun
Copy link
Member

@MrSltun MrSltun commented May 16, 2025

This PR resolves MOPRAT-840, MOPRAT-841

Description

This PR updates the Arrow__CircleFill Icons to use the Artsy Icons ones

Screenshots

Before After
Android image image
iOS image image

PR Checklist

  • I have tested my changes on the following platforms:
    • Android.
    • iOS.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos at least on Android, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • Update arrow circle fill icons to use Artsy Icons ones

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@MrSltun MrSltun self-assigned this May 16, 2025
@@ -18,7 +13,7 @@ export const ReserveNotMet = () => (

export const HighestBid = () => (
<>
<ArrowUpCircleFillIcon fill="green100" />
<ArrowheadUpCircleFillIcon height={16} width={16} fill="green100" />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had to update the size to 16 to look the same

@ArtsyOpenSource
Copy link
Contributor

This PR contains the following changes:

  • Cross-platform user-facing changes (Update arrow circle fill icons to use Artsy Icons ones - MrSltun)

Generated by 🚫 dangerJS against bf1e34b

@MrSltun MrSltun requested a review from Copilot May 16, 2025 16:46
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Arrow Circle Fill icons to use the latest Artsy Icons implementation. Key changes include:

  • Removing deprecated icon imports and using the new ArrowheadUpCircleFillIcon and ArrowheadDownCircleFillIcon components.
  • Setting explicit height and width properties for the new icons.
  • Upgrading the @artsy/icons dependency from version 3.30.0 to 3.35.0.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/app/Scenes/MyBids/Components/BiddingStatuses.tsx Replaced old icon components with updated Artsy Icons components and added explicit sizing props.
package.json Updated the @artsy/icons dependency version to incorporate the new icon components.
Comments suppressed due to low confidence (2)

src/app/Scenes/MyBids/Components/BiddingStatuses.tsx:16

  • [nitpick] Verify that the explicit dimensions (height=16 and width=16) for the new ArrowheadUpCircleFillIcon match the design specifications. Ensure consistency in icon sizing throughout the app.
<ArrowheadUpCircleFillIcon height={16} width={16} fill="green100" />

src/app/Scenes/MyBids/Components/BiddingStatuses.tsx:26

  • [nitpick] Confirm that setting explicit dimensions for ArrowheadDownCircleFillIcon is intended and consistent with the app's overall icon sizing guidelines.
<ArrowheadDownCircleFillIcon height={16} width={16} fill="red100" />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants